feat: implement bytes comparisons #7804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Jul 21, 2021
| @@ -118,6 +120,12 @@ private static ComparisonNullCheckFunction getNullCheckFunction( | |||
| return Optional.of((o1, o2) -> castLeft.cast(o1).compareTo(castRight.cast(o2))); | |||
| } else if (leftType == SqlBaseType.STRING) { | |||
| return Optional.of((o1, o2) -> o1.toString().compareTo(o2.toString())); | |||
| } else if (either(leftType, rightType, SqlBaseType.BYTES)) { | |||
There was a problem hiding this comment.
Does this mean you can compare BYTES with other types?
There was a problem hiding this comment.
It will eventually throw an error if either of them aren't BYTES. Updated to check that condition earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comparisons for BYTES - they are compared lexicographically using the
ByteByffer.compareTofunction.Testing done
QTT and unit tests.
Reviewer checklist