feat: add interface for metrics reporter #7788
Conversation
The added interface specify how to report metrics to a metrics framework. The implementations of this interface specify how to report to a specific metrics framework (e.g. JMX or Confluent's Telemetry pipeline)
|
@confluentinc It looks like @cadonna just signed our Contributor License Agreement. 👍 Always at your service, clabot |
| @@ -0,0 +1,112 @@ | |||
| /* | |||
| * Copyright 2018 Confluent Inc. | |||
| final Map<String, String> tags | ||
| ) { | ||
| this.name = Objects.requireNonNull(name, "name"); | ||
| this.time = time; |
There was a problem hiding this comment.
Just curious, why don't you require non-null for time and value?
| * | ||
| * @param dataPointSupplier supplier of the list of data points | ||
| */ | ||
| void report(Supplier<List<DataPoint>> dataPointSupplier); |
There was a problem hiding this comment.
Just to check my understanding - will there be a telemetry + jmx reporter that implement this interface / this method? and this method will be called from the metrics skeleton?
There was a problem hiding this comment.
Yes, there will be a Telemetry and a JMX implementation. On-prem the JMX reporter will be instantiated and in ccloud the telemetry reporter. Method report() will be called from the metrics skeleton.
| */ | ||
| class DataPoint { | ||
| private final String name; | ||
| private final Instant time; |
There was a problem hiding this comment.
@cadonna sorry I didn't catch this earlier - but why did you pick Instant here? JW because right now the metrics reporter skeleton usese Time / long
There was a problem hiding this comment.
@cadonna just for my own understanding: this framework would not be used for dd metrics / healthcheck metrics, right? It's only gonna used for telemetry in ccloud.
Description
The added interface specifies how to report metrics to a metrics
framework. The implementations of this interface specify how to
report to a specific metrics framework (e.g. JMX or Confluent's
Telemetry pipeline)
Testing done
No tests at this point since it is a plain interface.
Reviewer checklist