Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow for KSQL_GC_LOG_OPTS env variable to be passed through wit… #7577

Merged
merged 2 commits into from
May 27, 2021
Merged

fix: allow for KSQL_GC_LOG_OPTS env variable to be passed through wit… #7577

merged 2 commits into from
May 27, 2021

Conversation

thomas-tomlinson
Copy link
Contributor

@thomas-tomlinson thomas-tomlinson commented May 24, 2021 •
edited
Loading

Description

Testing done

Manually tested the behavior with the env variable specified and not specified.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@thomas-tomlinson thomas-tomlinson requested a review from a team as a code owner May 24, 2021 13:51
@ghost
Copy link

ghost commented May 24, 2021

@confluentinc It looks like @thomas-tomlinson just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@agavra agavra merged commit aa2ed0a into confluentinc:master May 27, 2021
@thomas-tomlinson thomas-tomlinson mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-tomlinson @agavra