fix: Fixes org.mock-server to be 5.11.2 to utilize newer netty #7458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Apr 30, 2021
mjsax
reviewed
Apr 30, 2021
| @@ -58,7 +58,7 @@ | |||
| <dependency> | |||
| <groupId>org.mock-server</groupId> | |||
| <artifactId>mockserver-netty</artifactId> | |||
| <version>3.10.4</version> | |||
| <version>5.11.2</version> | |||
There was a problem hiding this comment.
Why we we set this version explicitly and not inherit from top level pom?
Also, as we do set the version explicitly, how could it happen that the build broke? Seems we pulled in a different version somehow during runtime? Is there something wrong with our setup?
There was a problem hiding this comment.
My understanding is that another library from common, netty, overrode the version relied by on this library, to be a newer incompatible version. I effectively am upping the version of this library to now allow for a newer version of netty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes test and the build.
Testing done
Ran test
Reviewer checklist