feat: emit an error reason before closing websocket #7390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @swist just signed our Contributor License Agreement. 👍 Always at your service, clabot |
swist
force-pushed
the
kci-265/emit-non-truncated-query-errors
branch
5 times, most recently
from
23d647e to
4b7d1cc
Compare
Reasons for closing websocket are limited to 123 bytes. We can, however, emit a final message before closing the socket - we're using that here to send a non-truncated version of the error to display in the UI
swist
force-pushed
the
kci-265/emit-non-truncated-query-errors
branch
from
4b7d1cc to
ec96853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reasons for closing websocket are limited to 123 bytes.
We can, however, emit a final message before closing the
socket - we're using that here to send a non-truncated
version of the error to display in the UI
Reviewer checklist