fix: prevent IOB when printing topics with a key/value with an empty string #7162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @mmolimar just signed our Contributor License Agreement. 👍 Always at your service, clabot |
agavra
approved these changes
Mar 9, 2021
...est-app/src/main/java/io/confluent/ksql/rest/server/resources/streaming/RecordFormatter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When printing topics, the record formatter throws and Index Out of Bounds exception in case the key or value is an empty string because the deserializers might not have a format to use. This PR fix this checking if the possible formats are not empty.
Testing done
Included empty values in the tests which already exist to validate this behavior.
Reviewer checklist