refactor: use SqlArgument wrapper to look up functions #7011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpyzhang
force-pushed
the
sql-argument-refactor
branch
from
6e714b2 to
7cd498d
Compare
stevenpyzhang
force-pushed
the
sql-argument-refactor
branch
from
7cd498d to
9a121f9
Compare
lct45
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Thanks for pulling this out @stevenpyzhang , overall LGTM with a few questions/nits
| ) { | ||
| final SqlType sqlType = instance.getSqlType(); | ||
|
|
||
| // CHECKSTYLE_RULES.ON: CyclomaticComplexity |
There was a problem hiding this comment.
Is there a usual pattern for where we turn the checkstyle rules back on?
There was a problem hiding this comment.
Just following the other patterns, we usually turn it back on right after the method signature, I moved it up one line now
| import io.confluent.ksql.schema.ksql.types.SqlType; | ||
|
|
There was a problem hiding this comment.
Does the IDE add these random extra lines?
There was a problem hiding this comment.
Not sure where this came from, I removed it though
ksqldb-execution/src/main/java/io/confluent/ksql/execution/codegen/SqlToJavaVisitor.java
Outdated
Show resolved
Hide resolved
ksqldb-execution/src/main/java/io/confluent/ksql/execution/function/UdtfUtil.java
Outdated
Show resolved
Hide resolved
ksqldb-execution/src/main/java/io/confluent/ksql/execution/util/ExpressionTypeManager.java
Outdated
Show resolved
Hide resolved
stevenpyzhang
force-pushed
the
sql-argument-refactor
branch
from
dcb3ada to
4c36090
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses SqlArgument wrapper when looking up functions. This allows us in future PR's to handle non SqlType function arguments (such as lambdas)
PR looks large, but it's mainly just replacing instances of SqlType with SqlArgument in UDF lookup code.
Testing done
Updated unit tests, non functional change
Reviewer checklist