fix: get all available restore commands even on poll timeout #6985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesai
force-pushed
the
fix-command-topic-execution
branch
from
98018df to
23cdb16
Compare
agavra
approved these changes
Feb 10, 2021
our restore logic differentiates on restore behaviour vs live behaviour to avoid making some newly added referential integrity checks and therefore ensure we execute anything that was already logged. While this isn't the best way to guarantee compatibility, it's what we're doing now and we have a problem: sometimes the restore poll times out and returns no records, so we don't execute any restore phase. This patch fixes this by first sampling the end offset of the log and ensuring that all rows between the begin and end are returned.
rodesai
force-pushed
the
fix-command-topic-execution
branch
from
23cdb16 to
64b2ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our restore logic differentiates on restore behaviour vs "live" behaviour
to avoid making some newly added referential integrity checks and therefore
ensure we execute anything that was already logged. While this isn't the
best way to guarantee compatibility, it's what we're doing now and we have
a problem: sometimes the restore poll times out and returns no records,
so we don't execute any "restore" phase. This patch fixes this by first
sampling the end offset of the log and ensuring that all rows between the
begin and end are returned.
Testing done
Unit tests for command store. Restart of a running server.
Reviewer checklist