Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: type resolution for lambdas using a new sql type #6967

Closed
wants to merge 3 commits into from

Conversation

lct45
Copy link
Contributor

@lct45 lct45 commented Feb 8, 2021

Description

resolves unknown types in lambdas through a new SqlType.LAMBDA which allows us to store the input and return type of a lambda function and pass it to the UDF to properly identify the function. This PR would need to be updated to create a parent class for all regular SqlTypes and SqlLambda, so they become siblings of eachother, as SqlLambda does not need all the converters that a regular SqlType would.

Testing done

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

lct45 and others added 2 commits February 6, 2021 08:56
feat: add functions as UDF input types

fix immutable test

proof of concept lambda

follow up

extend lambda functionality

proof of concept lambda

feat: add lambda syntax to grammar

change g4

proof of concept lambda

initial type checking

bug fixes, clean up

clean-up and adding lambda sql type stuff

Type cleanup

adding contexts

cleanup

updating qtt

extending support for maps

Updating for multiple input types

Steven's ast fix + functional tests

cleaning up
@lct45 lct45 requested review from agavra and stevenpyzhang February 8, 2021 14:33
@lct45 lct45 requested a review from a team as a code owner February 8, 2021 14:33
@ghost
Copy link

ghost commented Feb 8, 2021

@confluentinc It looks like @lct45 just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@lct45 lct45 closed this Feb 10, 2021
@lct45 lct45 deleted the lambda_with_sql_type branch July 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants