fix: fix how the buffer limit check evaluates streams config #6876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer limit check first creates a dummy streams config to get the current max bytes buffering value. To do this it creates a map of the streams props and creates the config (with dummy values for all the required fields). However sometimes those fields are already provided and ImmutableMap doesn't like overwrites in the builder. So, use a plain old HashMap
vcrfxia
approved these changes
Jan 20, 2021
config/ksql-server.properties
Outdated
| @@ -20,7 +20,8 @@ | |||
| # The default is any IPv4 interface on the machine. | |||
| # NOTE: If set to wildcard or loopback set 'advertised.listener' to enable pull queries across machines | |||
| listeners=http://0.0.0.0:8088 | |||
|
|
|||
| ksql.service.id=test | |||
There was a problem hiding this comment.
This does not look like it's meant to be checked in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer limit check first creates a dummy streams config to get the current
max bytes buffering value. To do this it creates a map of the streams props and
creates the config (with dummy values for all the required fields). However
sometimes those fields are already provided and ImmutableMap doesn't like
overwrites in the builder. So, use a plain old HashMap.