fix: catch stack overflow error when parsing/preparing statements #6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Dec 7, 2020
agavra
approved these changes
Dec 8, 2020
| accumulator.visit(parseTree); | ||
| return accumulator.getSources(); | ||
| } catch (StackOverflowError e) { | ||
| throw new KsqlException("Error processing statement: Statement is too large to parse."); |
There was a problem hiding this comment.
nit: might make sense to include the GH ticket in the error message so that users can understand which part and what to do about it (namely, make the nested parenthesis less nested)
There was a problem hiding this comment.
I updated the error messages to suggest that nested expressions could be causing the error.
stevenpyzhang
force-pushed
the
large-where-clause-overflow
branch
2 times, most recently
from
41ff83c to
5b53318
Compare
spena
approved these changes
Dec 8, 2020
stevenpyzhang
force-pushed
the
large-where-clause-overflow
branch
from
5b53318 to
45e7efe
Compare
|
For some reason, I couldn't get the QTT test to pass on the PR builder even though it passes locally, it'd fail with another stack overflow error So I moved the test to KsqlResourceTest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5882
There were two possible places throwing the stack overflow error, while parsing/preparing.
One suggestion was to limit the Where clause size, but I don't think that's an optimal since it's possible to have a large where clause and not hit this issue. The error is being thrown when recursively trying to evaluate the boolean expression that's part of the Where clause, and the number of nested parentheses expressions is causing the deep recursion tree, but if the boolean expression was something like `Where ITM.ITEM_ID = '61151234123412345......(very long id)....12341234123412341', there wouldn't be the overflow, but the expression would have a large size.
So I just ended up catching the stack overflow error and throwing a more helpful exception.
Testing done
I Issued large where clause statement and verifying both error messages were returned.
Reviewer checklist