More informative help output for print-metrics #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurvam
reviewed
Jan 30, 2018
| "messages-consumed-avg: The average number of messages consumed by a query per second\n" + | ||
| "messages-consumed-min: Messages consumed per second for the query with the fewest messages consumed per second\n" + | ||
| "messages-consumed-max: Messages consumed per second for the query with the most messages consumed per second\n" + | ||
| "messages-produced-per-sec: Messages produced per second across all queries\n" + |
There was a problem hiding this comment.
consumed vs produced
| "messages-consumed-min: Messages consumed per second for the query with the fewest messages consumed per second\n" + | ||
| "messages-consumed-max: Messages consumed per second for the query with the most messages consumed per second\n" + | ||
| "messages-produced-per-sec: Messages produced per second across all queries\n" + | ||
| "error-rate: The number of messages which were consumed but not processed\n" + |
There was a problem hiding this comment.
perhaps add 'across all queries'?
apurvam
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.