-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use Java's Base64 instead of jersey's #6702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@confluentinc It looks like @niteshmor just signed our Contributor License Agreement. 👍 Always at your service, clabot |
niteshmor
changed the title
MINOR: use Java's Base64 instead of jersey's
fix: use Java's Base64 instead of jersey's
Dec 2, 2020
Using Jersey's private utility function prevent Jersey upgrades.
agavra
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dimitarndimitrov
added a commit
that referenced
this pull request
May 17, 2021
This is a partial backport of #6702.
2 tasks
dimitarndimitrov
pushed a commit
that referenced
this pull request
May 17, 2021
Using Jersey's private utility function prevent Jersey upgrades. Also force version consistency for jetty
2 tasks
dimitarndimitrov
added a commit
that referenced
this pull request
May 17, 2021
This is a partial backport of #6702.
dimitarndimitrov
added a commit
that referenced
this pull request
May 17, 2021
This is a partial backport of #6702.
dimitarndimitrov
added a commit
that referenced
this pull request
May 17, 2021
Using Jersey's private utility function prevent Jersey upgrades. Also force version consistency for jetty Co-authored-by: Dimitar Dimitrov <[email protected]> Co-authored-by: Nitesh Mor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using Jersey's private utility function prevent Jersey upgrades in upstream rest-utils. This pull request replaces jersey's Base64 utility with Java's built-in Base64 in two tests.
Testing done
Tests run by CI
Reviewer checklist