Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Java's Base64 instead of jersey's #6702

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

niteshmor
Copy link
Contributor

@niteshmor niteshmor commented Dec 2, 2020

Description

Using Jersey's private utility function prevent Jersey upgrades in upstream rest-utils. This pull request replaces jersey's Base64 utility with Java's built-in Base64 in two tests.

Testing done

Tests run by CI

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@ghost
Copy link

ghost commented Dec 2, 2020

@confluentinc It looks like @niteshmor just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@niteshmor niteshmor changed the title MINOR: use Java's Base64 instead of jersey's fix: use Java's Base64 instead of jersey's Dec 2, 2020
Using Jersey's private utility function prevent Jersey upgrades.
@niteshmor niteshmor marked this pull request as ready for review December 2, 2020 19:53
@niteshmor niteshmor requested a review from a team as a code owner December 2, 2020 19:53
@niteshmor niteshmor requested review from spena and vpapavas December 2, 2020 19:56
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niteshmor niteshmor merged commit f9fb523 into confluentinc:5.4.x Dec 2, 2020
dimitarndimitrov added a commit that referenced this pull request May 17, 2021
This is a partial backport of #6702.
dimitarndimitrov pushed a commit that referenced this pull request May 17, 2021
Using Jersey's private utility function prevent Jersey upgrades.
Also force version consistency for jetty
dimitarndimitrov added a commit that referenced this pull request May 17, 2021
This is a partial backport of #6702.
dimitarndimitrov added a commit that referenced this pull request May 17, 2021
dimitarndimitrov added a commit that referenced this pull request May 17, 2021
Using Jersey's private utility function prevent Jersey upgrades.
Also force version consistency for jetty

Co-authored-by: Dimitar Dimitrov <[email protected]>
Co-authored-by: Nitesh Mor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants