fix: Properly clean up state when executing a command fails #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesai
reviewed
Oct 15, 2020
| commandId, | ||
| (k, v) -> { | ||
| if (v == null) { | ||
| throw new IllegalStateException( |
There was a problem hiding this comment.
We could actually call this before the command is registered right? If something throws between generating the command id and enqueueing?
There was a problem hiding this comment.
That's true, it is possible.
Ok, now I just log when something is being aborted, but throw no error either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempts to cleanup and state associated with a command id when a transaction for that command fails to commit properly.
Fixes #6340
Testing done
Ran unit tests
Reviewer checklist