Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: protobuf format does not support unwrapping #6033

Merged

Conversation

big-andy-coates
Copy link
Contributor

Description

fixes: #5994

Fixes a unintuitive error should user set WRAP_SINGLE_VALUE=false with PROTOBUF format.

fixes: confluentinc#5994

Fixes a unintuitive error should user set `WRAP_SINGLE_VALUE=false` with `PROTOBUF` format.
@big-andy-coates big-andy-coates requested a review from agavra August 17, 2020 10:41
@big-andy-coates big-andy-coates requested a review from a team as a code owner August 17, 2020 10:41
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@big-andy-coates big-andy-coates merged commit 6c08e5d into confluentinc:master Aug 18, 2020
@big-andy-coates big-andy-coates deleted the protobuf_unwrapping branch August 18, 2020 08:47
sarwarbhuiyan pushed a commit to sarwarbhuiyan/ksql that referenced this pull request Sep 4, 2020
fixes: confluentinc#5994

Fixes a unintuitive error should user set `WRAP_SINGLE_VALUE=false` with `PROTOBUF` format.

Co-authored-by: Andy Coates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf allows WRAP_SINGLE_VALUES=false, but then fails on serde
3 participants