[Minor] Fix Variable initialization #602
Conversation
|
I'm wondering what do the team think about enabling style checks plugin? I noticed that KSQL inherits from confluent common, where the code style is defined. But code style issues de not fail the build. |
|
For some reason, commit fails and I cannot see why. Would it be possible to share the result of the build? @hjafarpour @miguno @dguy @bluemonk3y |
|
retest this pls |
|
Checkstyle is, or at least was enabled and should fail the build. However, i'm not sure which checkstyle rules it is using at this stage as there is clearly code that should fail the checks. Will need to investigate further |
| String udafName = getFunctionList().get(aggFunctionVarSuffix).getName() | ||
| .getSuffix(); | ||
| KsqlAggregateFunction aggregateFunction = functionRegistry.getAggregateFunction(udafName, | ||
| getFunctionList() | ||
| .get(aggFunctionVarSuffix).getArguments(), schema); | ||
| fieldSchema = aggregateFunction.getReturnType(); | ||
| Schema fieldSchema = aggregateFunction.getReturnType(); |
There was a problem hiding this comment.
Can probably take this one step further and just inline it. There is no reason for having the variable
|
retest this please |
|
my pleasure @dguy. Wondering when this patch can be merged? |
|
jenkins ran out of disk |
|
retest this please |
|
@bluemonk3y thanks for the information. What're your thoughts about having a public Travis CI build system? You can still have a private confluent Jenkins and ran all internal integration tests there. |
|
retest this please |
|
@dguy @bluemonk3y @hjafarpour locally it compiles without any problem. However, the branch contains flaky integration tests that fails the build. |
|
It is failing because there is no space left on the disk jenkins is using. Unfortunately we can't merge until we get a clean build. Sorry for the wait @satybald |
|
@dguy I tested it locally. I noticed that integration tests in serde module do not pass. |
|
retest this please |
|
Build finally passed. Thanks for your patience @satybald |
|
yea 🎉 |
Combine variable declartion and intiaztiona together.