Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport windowed table topic retention fixes #5842

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Jul 16, 2020

Description

Backport #5743 and #5835 to complete the feature implemented in https://github.com/confluentinc/ksql/pull/4733/files.

Testing done

Unit tests have also been backported. Also did a manual sanity check.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

vcrfxia added 2 commits July 16, 2020 15:37
…tinc#5743)

BREAKING CHANGE: ksqlDB now creates windowed tables with cleanup policy "compact,delete", rather than "compact". Also, topics that back streams are always created with cleanup policy "delete", rather than the broker default (by default, "delete").
@vcrfxia vcrfxia requested a review from a team as a code owner July 16, 2020 22:39
@vcrfxia vcrfxia changed the base branch from master to 6.0.x July 16, 2020 22:39
@vcrfxia
Copy link
Contributor Author

vcrfxia commented Jul 17, 2020

Merging without review as this is a straight-forward backport.

@vcrfxia vcrfxia merged commit b3db23c into confluentinc:6.0.x Jul 17, 2020
@vcrfxia vcrfxia deleted the backport-retention-fix branch July 17, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant