Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: /query-stream endpoint now defaults to auto.offset.reset=latest #5588

Merged

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Jun 9, 2020

Description

Fixes #5586

BREAKING CHANGE: The /query-stream endpoint previously defaulted to using auto.offset.reset=earliest. With this change, the new default is auto.offset.reset=latest, consistent with the /query endpoint and the ksqlDB CLI.

Testing done

Unit and integration tests continue to pass.

There's no test coverage for this default at the moment, since TestKsqlRestApp (used for all integration tests) sets auto.offset.reset=earliest on the server. As a result, the old default was also not tested and there is no testing regression in this PR, though we should consider plugging the gap in the future.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner June 9, 2020 22:36
@vcrfxia vcrfxia requested a review from purplefox June 9, 2020 22:36
Copy link
Contributor

@purplefox purplefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure it's a breaking change as we haven't documented the new API yet.

@vcrfxia
Copy link
Contributor Author

vcrfxia commented Jun 10, 2020

OK, I'll leave the breaking change out of the final commit message then (so it won't appear in the changelog). We should publish docs for the 0.10.0 release, though :)

@vcrfxia vcrfxia merged commit 49cfbb3 into confluentinc:6.0.x Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants