chore: Java client cleanup and additional integration tests (MINOR) #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
force-pushed
the
java-client-cleanup
branch
from
4ccc652 to
bde3ac6
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is stacked on #5448 and #5455, since both are required for the new integration tests. Only the latest two commits (starting with "chore: client cleanup") need to be reviewed.
A few miscellaneous changes in this PR:
Client#streamInserts()method, since this might not be implemented before the releaseStreamedQueryResult#close()method, since there was no use case for the existing functionalityauto.offset.reset=earliestTesting done
Tests pass.
Reviewer checklist