fix: Don't wait for streams thread to be in running state #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...reams/src/main/java/io/confluent/ksql/execution/streams/materialization/ks/KsStateStore.java
Outdated
Show resolved
Hide resolved
...reams/src/main/java/io/confluent/ksql/execution/streams/materialization/ks/KsStateStore.java
Outdated
Show resolved
Hide resolved
vinothchandar
approved these changes
Mar 27, 2020
| @@ -96,43 +82,21 @@ public void shouldThrowNPEs() { | |||
| new NullPointerTester() | |||
| .setDefault(KafkaStreams.class, kafkaStreams) | |||
| .setDefault(LogicalSchema.class, SCHEMA) | |||
| .setDefault(Supplier.class, clock) | |||
| .setDefault(KsqlConfig.class, ksqlConfig) | |||
| .testConstructors(KsStateStore.class, Visibility.PACKAGE); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldAwaitRunning() { | |||
|
|
||
| // When: | ||
| store.store(QueryableStoreTypes.sessionStore()); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldGetStoreOnceRunning() { | ||
| // Given: | ||
| when(kafkaStreams.state()).thenReturn(State.RUNNING); |
There was a problem hiding this comment.
can't understand this change fully
vpapavas
added a commit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When forwarding to standby is enabled as part of HA, we were still waiting for streams thread to reach running state. I moved the waiting to happen only when forwarding to standby is not enabled.
Testing done
Confirmed it works as expected via experiments on EC2 cluster
Reviewer checklist