Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add changelog for 0.8.0 release #4776

Merged
merged 7 commits into from
Mar 18, 2020

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Mar 14, 2020

Description

As the title says.

Testing done

Docs-only change.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner March 14, 2020 00:35
CHANGELOG.md Outdated
* Simple perf tool for new API ([#4590](https://github.com/confluentinc/ksql/pull/4590)) ([ee7ca8a](https://github.com/confluentinc/ksql/commit/ee7ca8a))
* support custom column widths in cli ([#4616](https://github.com/confluentinc/ksql/pull/4616)) ([42282cd](https://github.com/confluentinc/ksql/commit/42282cd))
* support JSON schema inference in ksqlDB ([#4563](https://github.com/confluentinc/ksql/pull/4563)) ([fcd6c7f](https://github.com/confluentinc/ksql/commit/fcd6c7f))
* support Protobuf in ksqlDB ([#4469](https://github.com/confluentinc/ksql/pull/4469)) ([a77cebe](https://github.com/confluentinc/ksql/commit/a77cebe))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcrfxia Can we nix "support Protobuf in ksqlDB (#4469) (a77cebe)" under 0.7.0 while we're at it? It looks like that was erroneously added a few releases ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- made the update. I think it happened because the PR was merged right after the 0.7.0 release was cut, before the changelog was generated. I'll make a note to be generate changelogs from commit hashes rather than directly from master to avoid this in the future.

CHANGELOG.md Outdated
* Integrate pull queries in new API([#4498](https://github.com/confluentinc/ksql/pull/4498)) ([cd7c058](https://github.com/confluentinc/ksql/commit/cd7c058))
* introduce JSON_SR format ([#4596](https://github.com/confluentinc/ksql/pull/4596)) ([daa04d2](https://github.com/confluentinc/ksql/commit/daa04d2))
* log groupby errors to processing logger ([#4575](https://github.com/confluentinc/ksql/pull/4575)) ([b503d25](https://github.com/confluentinc/ksql/commit/b503d25))
* Plug insert streams into backend ([#4512](https://github.com/confluentinc/ksql/pull/4512)) ([2482f0f](https://github.com/confluentinc/ksql/commit/2482f0f))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot in here about the new API server. I don't think they're meaningful to users. They're more sub-tasks of the feature, where the feature is a new API server.

I'd suggest dropping all of these:

  • basic auth for new API server
  • Integrate new API with existing security framework
  • Plug insert streams into backend
  • Provide upper limit on number of push queries
  • Simple perf tool for new API

If the new API is ready for release then it should have only a single mention IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I've removed them.

CHANGELOG.md Outdated
### Bug Fixes

* build ([#4767](https://github.com/confluentinc/ksql/pull/4767)) ([6f45803](https://github.com/confluentinc/ksql/commit/6f45803))
* fix test compile goal ([#4769](https://github.com/confluentinc/ksql/pull/4769)) ([4e8e601](https://github.com/confluentinc/ksql/commit/4e8e601))
Copy link
Contributor

@big-andy-coates big-andy-coates Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal: drop?

CHANGELOG.md Outdated

### Bug Fixes

* build ([#4767](https://github.com/confluentinc/ksql/pull/4767)) ([6f45803](https://github.com/confluentinc/ksql/commit/6f45803))
Copy link
Contributor

@big-andy-coates big-andy-coates Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal: drop?

CHANGELOG.md Outdated

* build ([#4767](https://github.com/confluentinc/ksql/pull/4767)) ([6f45803](https://github.com/confluentinc/ksql/commit/6f45803))
* fix test compile goal ([#4769](https://github.com/confluentinc/ksql/pull/4769)) ([4e8e601](https://github.com/confluentinc/ksql/commit/4e8e601))
* fix the half-fixed json decimal tests ([#4768](https://github.com/confluentinc/ksql/pull/4768)) ([d87b97d](https://github.com/confluentinc/ksql/commit/d87b97d))
Copy link
Contributor

@big-andy-coates big-andy-coates Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal: drop?

CHANGELOG.md Outdated
* decimals in structs should display as numeric ([#4165](https://github.com/confluentinc/ksql/pull/4165)) ([#4716](https://github.com/confluentinc/ksql/issues/4716)) ([7585d3c](https://github.com/confluentinc/ksql/commit/7585d3c))
* don't display decimals in scientific notation in CLI ([#4723](https://github.com/confluentinc/ksql/pull/4723)) ([3626f42](https://github.com/confluentinc/ksql/commit/3626f42))
* stop logging about command topic creation on startup if exists (MINOR) ([#4709](https://github.com/confluentinc/ksql/pull/4709)) ([f4cec0a](https://github.com/confluentinc/ksql/commit/f4cec0a))
* add functional-test dependencies to Docker module ([#4586](https://github.com/confluentinc/ksql/pull/4586)) ([b023cd0](https://github.com/confluentinc/ksql/commit/b023cd0)), closes [#4584](https://github.com/confluentinc/ksql/issues/4584)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an internal thing or related to our testing tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a fix to the testing tool, and it's actually the reason the 0.7.1 point release was created. Which brings up a good question -- should changes included in the 0.7.1 release also be included in the 0.8.0 changelog, or no? (Asked differently, should the 0.8.0 changelog include new changes since 0.7.0 or only new changes since 0.7.1?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard practice is to only include new things since the last point release. So in this case only new stuff after 0.7.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Removed the 0.7.1 changes from the 0.8.0 changelog.

* stop logging about command topic creation on startup if exists (MINOR) ([#4709](https://github.com/confluentinc/ksql/pull/4709)) ([f4cec0a](https://github.com/confluentinc/ksql/commit/f4cec0a))
* add functional-test dependencies to Docker module ([#4586](https://github.com/confluentinc/ksql/pull/4586)) ([b023cd0](https://github.com/confluentinc/ksql/commit/b023cd0)), closes [#4584](https://github.com/confluentinc/ksql/issues/4584)
* added special handling for forwarded pull query request ([#4597](https://github.com/confluentinc/ksql/pull/4597)) ([ba4fe74](https://github.com/confluentinc/ksql/commit/ba4fe74))
* backport fixes from query close ([#4662](https://github.com/confluentinc/ksql/pull/4662)) ([8168002](https://github.com/confluentinc/ksql/commit/8168002))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #4704?

CHANGELOG.md Outdated
* don't cleanup topics on engine close ([#4658](https://github.com/confluentinc/ksql/pull/4658)) ([a8ecb72](https://github.com/confluentinc/ksql/commit/a8ecb72))
* idempotent terminate that can handle hung streams ([#4643](https://github.com/confluentinc/ksql/pull/4643)) ([2dc0727](https://github.com/confluentinc/ksql/commit/2dc0727))
* patch KafkaStreamsInternalTopicsAccessor as KS internals changed ([#4621](https://github.com/confluentinc/ksql/pull/4621)) ([eb07370](https://github.com/confluentinc/ksql/commit/eb07370))
* support partial schemas ([#4625](https://github.com/confluentinc/ksql/pull/4625)) ([91dfc36](https://github.com/confluentinc/ksql/commit/91dfc36))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More a feature than a bug fix. (Probably my fault)

CHANGELOG.md Outdated
* idempotent terminate that can handle hung streams ([#4643](https://github.com/confluentinc/ksql/pull/4643)) ([2dc0727](https://github.com/confluentinc/ksql/commit/2dc0727))
* patch KafkaStreamsInternalTopicsAccessor as KS internals changed ([#4621](https://github.com/confluentinc/ksql/pull/4621)) ([eb07370](https://github.com/confluentinc/ksql/commit/eb07370))
* support partial schemas ([#4625](https://github.com/confluentinc/ksql/pull/4625)) ([91dfc36](https://github.com/confluentinc/ksql/commit/91dfc36))
* Tests should use free port for servers ([#4595](https://github.com/confluentinc/ksql/pull/4595)) ([0176721](https://github.com/confluentinc/ksql/commit/0176721))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal: drop?

Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vcrfxia

@vcrfxia vcrfxia changed the title docs: add changelog for 0.8.0 release (WIP) docs: add changelog for 0.8.0 release Mar 17, 2020
Copy link
Contributor

@derekjn derekjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcrfxia vcrfxia merged commit a3aeaef into confluentinc:master Mar 18, 2020
@vcrfxia vcrfxia deleted the 0.8.0-changelog branch March 18, 2020 23:38
JimGalasyn added a commit that referenced this pull request Mar 19, 2020
) (#4824)

* docs: update etc/ksql dir to ksqldb in on-prem topics (DOCS-3685) (#4804)

* docs: bump ksqlDB docs version to 0.8.0 (DOCS-3688) (#4808)

* docs: fix broken example output in ksqlDB tutorial topic (DOCS-3698) (#4817)

* docs: add blog link per DevX request (DOCS-3691) (#4818)

* docs: add changelog for 0.8.0 release (#4776)

* docs: update embedded dockerfile and command with token (DOCS-3702) (#4820)

Co-authored-by: Victoria Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants