fix: pull queries should work across nodes #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: confluentinc#4142 Fixes: confluentinc#4151 Fixes: confluentinc#4152 Introduces a new `inter.node.listener` that can be used to specify a URL that the node can be contacted on by other nodes. This can be different to the listeners defined in `listeners`. This can be required if `listeners` is set to a wildcard address, i.e. IPv4 `0.0.0.0` or IPv6 `[::]`, or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL. If `inter.node.listener` is not set it still defaults to the first listener in `listener` config. However, it now replaces an wildcard address with `localHost`. This means inter-node comms is still possible for nodes running on the same host. Warnings are logged if the inter-node listener resolves to a loopback or local address.
Conflicting files ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/KsqlRestConfig.java
2 tasks
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/KsqlRestConfig.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/KsqlRestConfig.java
Show resolved
Hide resolved
|
Hey @big-andy-coates , should the |
It's potentially used to set |
AlanConfluent
approved these changes
Dec 19, 2019
big-andy-coates
added a commit
to big-andy-coates/ksql
that referenced
this pull request
Jan 10, 2020
Backport of confluentinc#4169 Fixes: confluentinc#4142 Fixes: confluentinc#4151 Fixes: confluentinc#4152 Introduces a new `inter.node.listener` that can be used to specify a URL that the node can be contacted on by other nodes. This can be different to the listeners defined in `listeners`. This can be required if `listeners` is set to a wildcard address, i.e. IPv4 `0.0.0.0` or IPv6 `[::]`, or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL. If `inter.node.listener` is not set it still defaults to the first listener in `listener` config. However, it now replaces an wildcard address with `localHost`. This means inter-node comms is still possible for nodes running on the same host. Warnings are logged if the inter-node listener resolves to a loopback or local address. (cherry picked from commit 0ac71cf)
2 tasks
|
Backported to 5.4.x in #4271. (Should be released in 5.4.1) |
big-andy-coates
added a commit
that referenced
this pull request
Jan 26, 2020
Backport of #4169 Fixes: #4142 Fixes: #4151 Fixes: #4152 Introduces a new `inter.node.listener` that can be used to specify a URL that the node can be contacted on by other nodes. This can be different to the listeners defined in `listeners`. This can be required if `listeners` is set to a wildcard address, i.e. IPv4 `0.0.0.0` or IPv6 `[::]`, or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL. If `inter.node.listener` is not set it still defaults to the first listener in `listener` config. However, it now replaces an wildcard address with `localHost`. This means inter-node comms is still possible for nodes running on the same host. Warnings are logged if the inter-node listener resolves to a loopback or local address. (cherry picked from commit 0ac71cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4142
Fixes: #4151
Fixes: #4152
Introduces a new
inter.node.listenerthat can be used to specify a URL that the node can be contacted on by other nodes. This can be different to the listeners defined inlisteners. This can be required iflistenersis set to a wildcard address, i.e. IPv40.0.0.0or IPv6[::], or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL.If
inter.node.listeneris not set it still defaults to the first listener inlistenerconfig. However, it now replaces an wildcard address withlocalHost. This means inter-node comms is still possible for nodes running on the same host.Warnings are logged if the inter-node listener resolves to a loopback or local address.
Testing done
Usual.
Manual testing using two node docker KSQL cluster, using
KSQL_LISTENERS: http://0.0.0.0:8088: the wildcard address is correctly replaced withlocalhostwhen used to share with other nodes. Optionally, can setKSQL_ADVERTISED_LISTENERto expose KSQL beyond local machine.Reviewer checklist