Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decimals in structs should display as numeric #4165

Merged
merged 1 commit into from
Dec 18, 2019
Merged

fix: decimals in structs should display as numeric #4165

merged 1 commit into from
Dec 18, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Dec 17, 2019

fixes #4118

Description

Decimals are not properly displayed in the CLI:

ksql> SELECT * FROM NESTED_DECIMALS EMIT CHANGES;
+------------------------------+------------------------------+------------------------------+
|ROWTIME                       |ROWKEY                        |VAL                           |
+------------------------------+------------------------------+------------------------------+
|1576622159874                 |null                          |{DEC=2.1}                     |

Testing done

  • unit test
  • local testings

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner December 17, 2019 23:06
spena
spena approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agavra agavra merged commit 75b539e into confluentinc:master Dec 18, 2019
@agavra agavra deleted the decimal_display branch December 18, 2019 16:37
big-andy-coates pushed a commit to big-andy-coates/ksql that referenced this pull request Mar 5, 2020
@agavra @big-andy-coates
fix: decimals in structs should display as numeric (confluentinc#4165)
619aa09 
(cherry picked from commit 75b539e)
big-andy-coates added a commit that referenced this pull request Mar 10, 2020
@big-andy-coates
fix: decimals in structs should display as numeric (#4165) (#4716)
7585d3c 
(cherry picked from commit 75b539e)

Co-authored-by: Andy Coates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVRO Decimals in Structs are displayed as base64
2 participants
@agavra @spena