Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UncaughtExceptionHandler not being set for Persistent Queries #4087

Merged
merged 1 commit into from
Dec 9, 2019
Merged

fix: UncaughtExceptionHandler not being set for Persistent Queries #4087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ksql-engine/src/main/java/io/confluent/ksql/query/KafkaStreamsBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

package io.confluent.ksql.query;

import io.confluent.ksql.util.KafkaStreamsUncaughtExceptionHandler;
import java.util.Map;
import java.util.Objects;
import java.util.Properties;
Expand All @@ -40,6 +41,7 @@ public BuildResult buildKafkaStreams(
props.putAll(conf);
final Topology topology = builder.build(props);
final KafkaStreams kafkaStreams = new KafkaStreams(topology, props, clientSupplier);
kafkaStreams.setUncaughtExceptionHandler(new KafkaStreamsUncaughtExceptionHandler());
return new BuildResult(topology, kafkaStreams);
}
}
3 changes: 0 additions & 3 deletions ksql-engine/src/main/java/io/confluent/ksql/query/QueryExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
import io.confluent.ksql.serde.GenericKeySerDe;
import io.confluent.ksql.serde.KeyFormat;
import io.confluent.ksql.services.ServiceContext;
import io.confluent.ksql.util.KafkaStreamsUncaughtExceptionHandler;
import io.confluent.ksql.util.KsqlConfig;
import io.confluent.ksql.util.KsqlConstants;
import io.confluent.ksql.util.KsqlException;
Expand Down Expand Up @@ -163,8 +162,6 @@ public TransientQueryMetadata buildTransientQuery(
final BuildResult built =
kafkaStreamsBuilder.buildKafkaStreams(streamsBuilder, streamsProperties);

built.kafkaStreams.setUncaughtExceptionHandler(new KafkaStreamsUncaughtExceptionHandler());

final LogicalSchema transientSchema = buildTransientQuerySchema(schema);

return new TransientQueryMetadata(
Expand Down