test: serialize/deserialize plans from qtt

[rodesai]

Extends qtt to build the query plan and deserialize/serialize it
before executing. Should be enough to make sure plans are serializable
and executable until we improve qtt.

[rodesai]

For some reason Jackson complains it can't deserialize into ImmutableList when using the JsonCreator (even though it ultimately just calls this constructor). So I switched this class to use a custom deserializer.

[big-andy-coates]

It's because there is a getter called getContext, so its checking out the private final ImmutableList<String> context; field. Mark getContext as @JsonIgnore and you'll be golden.

[rodesai]

Added this because when deserializing ddl schemas we do want the implicit columns.

[big-andy-coates]

Out of interest, is it just ROWTIME you need? I'm hoping to completely remove the concept of 'implicit' column soon by:

1. making ROWTIME a pseudo column
2. explicitly adding ROWTIME in CT/CS statements if a key column is not provided.

[rodesai]

explicitly adding ROWTIME in CT/CS statements if a key column is not provided

you mean ROWKEY?

[big-andy-coates]

Thanks @rodesai, LGTM

[big-andy-coates]

It's because there is a getter called getContext, so its checking out the private final ImmutableList<String> context; field. Mark getContext as @JsonIgnore and you'll be golden.

[big-andy-coates]

nit: don't think this suppression is needed

[big-andy-coates]

It's a style thing, but I generally think that if you've got some part of the code in a function that wants its own try/catch, it generally makes the code more readable to move it to its own function, e.g.

  private static ExecuteResult executeConfiguredStatement(
      final KsqlExecutionContext executionContext,
      final ConfiguredStatement<?> stmt
  ) {
    final KsqlPlan plan = executionContext.plan(executionContext.getServiceContext(), stmt);
    final ConfiguredKsqlPlan configuredPlan = buildConfiguredKsqlPlan(stmt, plan);
    return executionContext.execute(executionContext.getServiceContext(), configuredPlan);
  }

  private static ConfiguredKsqlPlan buildConfiguredKsqlPlan(
      final ConfiguredStatement<?> stmt,
      final KsqlPlan plan
  ) {
    try {
      final String serialized = PLAN_MAPPER.writeValueAsString(plan);
      return ConfiguredKsqlPlan.of(
          PLAN_MAPPER.readValue(serialized, KsqlPlan.class),
          stmt.getOverrides(),
          stmt.getConfig()
      );
    } catch (final IOException e) {
      throw new RuntimeException(e);
    }
  }

[big-andy-coates]

Maybe throw a TestFrameworkException?

[big-andy-coates]

Out of interest, is it just ROWTIME you need? I'm hoping to completely remove the concept of 'implicit' column soon by:

1. making ROWTIME a pseudo column
2. explicitly adding ROWTIME in CT/CS statements if a key column is not provided.