fix: the Abs, Ceil and Floor methods now return proper types #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,67 @@ | |||
| /* | |||
| * Copyright 2018 Confluent Inc. | |||
There was a problem hiding this comment.
so many derps 🤦♂ - this is what I get for thinking this was an "easy PR" and not paying attention to details. Thanks for catching them @stevenpyzhang!
ksql-engine/src/main/java/io/confluent/ksql/function/udf/math/Ceil.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/main/java/io/confluent/ksql/function/udf/math/Ceil.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/main/java/io/confluent/ksql/function/udf/math/Floor.java
Outdated
Show resolved
Hide resolved
stevenpyzhang
approved these changes
Nov 22, 2019
ksql-engine/src/main/java/io/confluent/ksql/function/InternalFunctionRegistry.java
Outdated
Show resolved
Hide resolved
agavra
force-pushed
the
return_types
branch
2 times, most recently
from
50d9675 to
1cb4f45
Compare
BREAKING CHANGE: abs, ceil and floor will now return types aligned with other databases systems (i.e. the same type as the input). Previously these udfs would always return Double.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: abs, ceil and floor will now return types aligned with
other databases systems (i.e. the same type as the input). Previously
these udfs would always return Double.
fixes #3790
Testing done
math.jsonReviewer checklist