fix: be more lax on validating config #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: confluentinc#2279 KSQL should allow any property to be passed to producers and consumers as the can be used to initialize things such as interceptors. We can not know ahead of time what the properties a custom interceptor needs, hence we can't exclude any settings we see.
purplefox
approved these changes
Oct 17, 2019
ksql-common/src/main/java/io/confluent/ksql/config/KsqlConfigResolver.java
Outdated
Show resolved
Hide resolved
|
@big-andy-coates we should document that these will get written out to the command topic without any validation. The original intent behind resolving all the configs was so that we could obfuscate secrets passed in as config when writing them out to kafka and/or logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #2279
KSQL should allow any property to be passed to producers and consumers as the can be used to initialize things such as interceptors.
We can not know ahead of time what the properties a custom interceptor needs, hence we can't exclude any settings we see.
Testing done
tests added.
Reviewer checklist