refactor: remove ExecutionContext.execute(stmt) completely #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I just realized that this refactoring of the KsqlExecutionContext right now is very similar to the work @rodesai is doing in #3482. The KsqlExecutionContext is quite different after his change. I think this can be done in parallel with Rohan's pr (especially since part 1 for this was already merged), but I think we could maybe just include all this refactoring in Rohan's pr since he'll be changing the interface anyways. (edit: never mind, I just saw your comments in his pr, disregard this comment then). |
big-andy-coates
approved these changes
Oct 14, 2019
spena
force-pushed
the
remove_execute_statement_part2
branch
from
79d43f4 to
0002ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part2 of #3530.
This PR replaces the rest of the classes using
ExecutionContext.execute(stmt)forExecutionContext.execute(ctx, stmt), and finally removes the method from theExecutionContextinterface.Testing done
Updated unit tests.
Reviewer checklist