Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: start updating docs to include EMIT CHANGES for push queries #3472

Merged
merged 2 commits into from
Oct 4, 2019
Merged

docs: start updating docs to include EMIT CHANGES for push queries #3472

merged 2 commits into from
Oct 4, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

Updated the demo inline with recent changes to KSQL including:

  • push queries now need EMIT CHANGES.
  • added pull query example
  • PRINT is now case-sensitive and does not require quotes.
  • formatting of tables has changed
  • etc

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested review from JimGalasyn and a team as code owners October 3, 2019 20:35
JimGalasyn
JimGalasyn approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks!

@big-andy-coates big-andy-coates merged commit 691569f into confluentinc:master Oct 4, 2019
@big-andy-coates big-andy-coates deleted the emit_changes_docs branch October 4, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @JimGalasyn