feat: remove equalsIgnoreCase from all Name classes (MINOR) #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Sep 26, 2019
| @@ -131,7 +131,7 @@ public ConnectSchema valueConnectSchema() { | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| public Optional<Column> findColumn(final String columnName) { | |||
| private Optional<Column> findColumn(final String columnName) { | |||
There was a problem hiding this comment.
Do we still need the @VisibleForTesting annotation if the method is private?
There was a problem hiding this comment.
derp! I'll fix this in a follow-up PR so I don't have to re-test (i'm touching this code anyway). Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't ever actually need to compare ignoring case because
ParserUtilwill parse anything unquoted into upper case.This patch also includes some very minor refactors and javadoc improvements.
Testing done
mvn clean installReviewer checklist