feat: move toTable kstreams calls to plan builder #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
approved these changes
Sep 12, 2019
| @Override | ||
| public List<ExecutionStep<?>> getSources() { | ||
| return ImmutableList.of(source); | ||
| } | ||
|
|
||
| public ExecutionStep<S> getSource() { |
There was a problem hiding this comment.
Is this necessary? Seems like API bloat, when the caller could just call getSources().get(0).
There was a problem hiding this comment.
I've left this in so that I can get the source with type parameters.
This patch moves converting from a kstream to a ktable to the plan builder, and cleans up that code (and tests) from SchemaKStream and DataSourceNode
rodesai
force-pushed
the
move-stream-to-table-to-execution
branch
from
25f1a29 to
cbca611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch moves converting from a kstream to a ktable to the plan
builder, and cleans up that code (and tests) from SchemaKStream and
DataSourceNode
Testing done
added unit tests for the new step builder
Reviewer checklist