-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quoted reserved identifier 5.3 #3225
Fix quoted reserved identifier 5.3 #3225
Conversation
This is a partial backport from PR-3194
Backport PR-3222
da29047
to
2f970cf
Compare
2f970cf
to
3c7cdae
Compare
} | ||
|
||
@Override | ||
protected Void visitSetProperty(final SetProperty node, final Integer context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agavra I had to support SET and UNSET here because the KsqlEngineTest
tests were failing (shouldSetPropertyInRunScript and shouldUnsetPropertyInRunScript).
But now the ensure-formatter.json
is failing because SET is supported.
- Having SET supported in SqlFormatter is good?
- Should I remove the two test cases above (they're not in master)
- Or, should I add a different statement in the ensure-formatter that fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... SET support is a good thing. I just couldn't think of another good way for ensure-formatter
to work. I'm happy to get suggestions. (I don't think we should remove the existing tests because 5.3. depends on that). One option is to remove ensure-formatter
for this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it so I can move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we're going to need to figure out how to merge this with master (we'll need to update ensure-formatter.sql if we're adding support for SET/UNSET in the formatter)
9d79974
to
1cb4bda
Compare
Thanks @agavra, I found that |
Description
This is a backport from #3222
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist