refactor: move expressions into ksql-execution #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch looks big, but its really just moving the expression tree into ksql-execution under the package io.confluent.ksql.execution.expression.tree. The only big code change required to do this was to make the reserved word check done in ExpressionFormatter a parameter, and to write a thin wrapper in ksql-parser that passes in the predicate that checks for words in the KSQL grammar.
rodesai
force-pushed
the
move-expressions-to-execution-rebase
branch
from
d74a0c3 to
7c83377
Compare
agavra
approved these changes
Aug 12, 2019
ksql-parser/src/main/java/io/confluent/ksql/parser/ExpressionFormatterUtil.java
Outdated
Show resolved
Hide resolved
ksql-parser/src/test/java/io/confluent/ksql/parser/ExpressionFormatterUtilTest.java
Outdated
Show resolved
Hide resolved
…ormatterUtil.java Co-Authored-By: Almog Gavra <[email protected]>
…ormatterUtilTest.java Co-Authored-By: Almog Gavra <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch looks big, but its really just moving the expression tree into ksql-execution
under the package io.confluent.ksql.execution.expression.tree.
The only major code change required to do this was to make the reserved word check done
in ExpressionFormatter a parameter, and to write a thin wrapper in ksql-parser that passes
in the predicate that checks for words in the KSQL grammar. ExpressionFormatter is now in
ksql-execution, and the wrappers are in a new util class called ExpressionFormatterUtil.
Testing done
No new tests since we're just moving stuff around.