refactor: Run QTT using the testing tool #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'upstream/master' into QTT-using-testing-tool
hjafarpour
commented
Aug 6, 2019
| ] | ||
| }, | ||
| { | ||
| "name": "import session stream and group by", |
There was a problem hiding this comment.
This test is incorrect since at the moment kstreams does not support reading windowed key and aggregating on it!
hjafarpour
commented
Aug 6, 2019
| {"topic": "S2", "key": "0 : Window{start=0 end=10000}", "value": "0 : Window{start=0 end=10000},1", "timestamp": 10000}, | ||
| {"topic": "S2", "key": "1 : Window{start=10000 end=10000}", "value": "1 : Window{start=10000 end=10000},1", "timestamp": 10000}, | ||
| {"topic": "S2", "key": "1 : Window{start=10000 end=10000}", "value": "1 : Window{start=10000 end=10000},2", "timestamp": 10000} | ||
| {"topic": "S2", "key": 0, "value": "0,0", "timestamp": 0, "window": {"start": 0, "end": 9223372036854775807, "type": "time"}}, |
There was a problem hiding this comment.
The end of the window should be Long.MAX_VALUE since in legacy mode we read this as a time window with no size.
hjafarpour
changed the title
agavra
previously requested changes
Aug 7, 2019
...tional-tests/src/main/java/io/confluent/ksql/test/serde/avro/ValueSpecAvroSerdeSupplier.java
Outdated
Show resolved
Hide resolved
...tional-tests/src/main/java/io/confluent/ksql/test/serde/avro/ValueSpecAvroSerdeSupplier.java
Show resolved
Hide resolved
...tional-tests/src/main/java/io/confluent/ksql/test/serde/avro/ValueSpecAvroSerdeSupplier.java
Outdated
Show resolved
Hide resolved
...tional-tests/src/main/java/io/confluent/ksql/test/serde/avro/ValueSpecAvroSerdeSupplier.java
Outdated
Show resolved
Hide resolved
ksql-functional-tests/src/main/java/io/confluent/ksql/test/model/TopicNode.java
Outdated
Show resolved
Hide resolved
ksql-functional-tests/src/main/java/io/confluent/ksql/test/tools/TestCase.java
Outdated
Show resolved
Hide resolved
ksql-functional-tests/src/main/java/io/confluent/ksql/test/tools/TestCase.java
Show resolved
Hide resolved
ksql-functional-tests/src/test/java/io/confluent/ksql/test/EndToEndEngineTestUtil.java
Outdated
Show resolved
Hide resolved
ksql-functional-tests/src/test/java/io/confluent/ksql/test/EndToEndEngineTestUtil.java
Show resolved
Hide resolved
agavra
approved these changes
Aug 9, 2019
...tional-tests/src/main/java/io/confluent/ksql/test/serde/avro/ValueSpecAvroSerdeSupplier.java
Outdated
Show resolved
Hide resolved
...tional-tests/src/main/java/io/confluent/ksql/test/serde/avro/ValueSpecAvroSerdeSupplier.java
Outdated
Show resolved
Hide resolved
...tional-tests/src/main/java/io/confluent/ksql/test/serde/avro/ValueSpecAvroSerdeSupplier.java
Outdated
Show resolved
Hide resolved
ksql-functional-tests/src/main/java/io/confluent/ksql/test/tools/Topic.java
Outdated
Show resolved
Hide resolved
ksql-functional-tests/src/test/java/io/confluent/ksql/test/EndToEndEngineTestUtil.java
Outdated
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the QTT execution to use the testing tool. QTTs will be a special case for the testing tool where we only run one query!
The PR handles
KSQL_WINDOWED_SESSION_KEY_LEGACY_CONFIG, however, we should remove it after resolving #3179 .I also fixed a bug with the union types in the QTT where we did not distinguish between unions of two and more than two elements.
Also I fixed a bug in QTT where the map entries were not converted correctly into avro format.
Testing:
All QTT tests run correctly with the new flow.
Reviewer checklist