feat: add Logarithm, Exponential and Sqrt functions #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chappers <[email protected]>
2 tasks
rodesai
approved these changes
Jul 17, 2019
| @@ -0,0 +1,63 @@ | |||
| /* | |||
| * Copyright 2018 Confluent Inc. | |||
| description = "the exponent to raise e to." | ||
| ) final Double exponent | ||
| ) { | ||
| if (exponent == null) { |
There was a problem hiding this comment.
nit: return exponent == null ? null : Math.exp(exponent);
| import io.confluent.ksql.util.KsqlConstants; | ||
|
|
||
| @UdfDescription( | ||
| name = "log", |
There was a problem hiding this comment.
Maybe we should name this function ln and use log for a function that accepts a base? I don't really have a strong preference though - different systems seem to do different things here. Postgres uses ln. Mysql uses both ln and log, and log w/ 1 parameter takes a natural log logarithm - so we're consistent with that.
agavra
approved these changes
Jul 17, 2019
| @@ -1581,6 +1583,8 @@ Scalar functions | |||
| +------------------------+---------------------------------------------------------------------------+---------------------------------------------------+ | |||
| | LEN | ``LEN(col1)`` | The length of a string. | | |||
| +------------------------+---------------------------------------------------------------------------+---------------------------------------------------+ | |||
| | LOG | ``LOG(col1)`` | The natural logarithm of a value. | | |||
There was a problem hiding this comment.
I think you have a too many spaces for |
|
|
||
| final double result = Math.log(value); | ||
| if (Double.isNaN(result)) { | ||
| throw new KsqlFunctionException("Result was NaN"); |
There was a problem hiding this comment.
why should these throw exceptions instead of leaving it up to the serialization format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
Log,ExpandSQRTUDFS.As originally proposed in #2302 by @chappers
Co-authored-by: chappers [email protected]
Testing done
Added suitable unit and QTT
Reviewer checklist