fix: check for other sources using a topic before deleting #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
approved these changes
Jul 12, 2019
| @@ -75,6 +78,26 @@ public TopicDeleteInjector( | |||
| Objects.requireNonNull(schemaRegistryClient, "schemaRegistryClient"); | |||
| } | |||
|
|
|||
| private void checkTopicRefs(final DataSource<?> source) { | |||
There was a problem hiding this comment.
super nit: private methods to the bottom of class files, not interspersed with the public API.
| .filter(s -> s.getKafkaTopicName().equals(topicName)) | ||
| .map(s -> s.getName()) | ||
| .filter(name -> !sourceName.equals(name)) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Rather than create a list, you can just build the string you need later:
final String using = sources.values().stream()
.filter(s -> s.getKafkaTopicName().equals(topicName))
.map(s -> s.getName())
.filter(name -> !sourceName.equals(name))
.collect(Collectors.joining(", "));
if (!using.isEmpty()) {
throw new KsqlException(
String.format(
"Refusing to delete topic. Found other data sources (%s) using topic %s",
using,
topicName
)
);
}
big-andy-coates
requested review from
a team,
vcrfxia,
hjafarpour,
agavra and
spena
and removed request for
a team
When handling DELETE TOPIC, check that other sources don't use the topic before deleting. This is an optimistic check - the user could still delete topics out from under us, and its not safe racing against concurrent statements. But, we've seen single users kick themselves this way in the past, so this should help in those cases.
rodesai
force-pushed
the
check-topic-refs-before-delete
branch
from
4da9686 to
aa9319e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling DELETE TOPIC, check that other sources don't use the topic
before deleting. This is an optimistic check - the user could still delete
topics out from under us, and its not safe racing against concurrent statements.
But, we've seen single users kick themselves this way in the past, so this should
help in those cases.