Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Only look up index of new key field once, not per row processed (MINOR) #3020

Merged
merged 1 commit into from
Jun 28, 2019
Merged

perf: Only look up index of new key field once, not per row processed (MINOR) #3020

merged 1 commit into from
Jun 28, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

On a selectKey the old code looks up the index of the new key field in the value schema per-row processed. This index is constant and can be pre-calculated just the once.

Testing done

mvn test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
perf: Only look up index of new key field once, not per row processed
1e27419 
On a `selectKey` the old code looks up the index of the new key field in the value schema per-row processed. This index is constant and can be pre-calculated just the once.
@big-andy-coates big-andy-coates requested a review from a team as a code owner June 27, 2019 11:43
agavra
agavra approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤑 🤑 🤑

@agavra agavra requested a review from a team June 27, 2019 16:02
rodesai
rodesai approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@big-andy-coates big-andy-coates merged commit fda1c7f into confluentinc:master Jun 28, 2019
@big-andy-coates big-andy-coates deleted the key_index branch June 28, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

@rodesai rodesai rodesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@big-andy-coates @rodesai @agavra