Drop requirement that CREATE TABLE statements have a KEY set in WITH clause
#2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Apr 29, 2019
...-common/src/main/java/io/confluent/ksql/util/timestamp/TimestampExtractionPolicyFactory.java
Outdated
Show resolved
Hide resolved
Conflicting files ksql-engine/src/main/java/io/confluent/ksql/ddl/commands/AbstractCreateStreamCommand.java ksql-engine/src/main/java/io/confluent/ksql/ddl/commands/CreateTableCommand.java ksql-engine/src/main/java/io/confluent/ksql/planner/plan/JoinNode.java ksql-engine/src/test/java/io/confluent/ksql/ddl/commands/AbstractCreateStreamCommandTest.java ksql-engine/src/test/java/io/confluent/ksql/ddl/commands/CommandFactoriesTest.java
Conflicting files ksql-engine/src/test/java/io/confluent/ksql/planner/plan/JoinNodeTest.java
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop requirement that
CREATE TABLEstatements have aKEYset inWITHclauseFixes #2745
This also fixes a hole in the current KSQL where any table without a key field set can be used in a join by any column, i.e. it should throw an error, but does not.
Still todo:
JoinNodeTestto cover new functionality once Fix Joining on ROWKEY #2735 is mergedTesting done
Updated
key-fields.jsontest accordingly and unit tests.Reviewer checklist