-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KLIP-3: WITH OUTPUT_SCHEMA #2679
KLIP-3: WITH OUTPUT_SCHEMA #2679
Conversation
It looks like @TobiasHauck hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
@confluentinc It looks like @TobiasHauck just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
||
## Design | ||
|
||
The new ```WITH``` property is analyzed by the Analyzer and stored in the Query Analysis. That information is processed by the query engine and used by the AvroSerializer (KsqlAvroTopicSerDe). KsqlAvroTopicSerDe uses the schema registry client to get the latest metadata of the related output schema and uses this schema instead of the current one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't think require KSQL to validate that the selected schema is compatible with the actual data being produced? Is there a schema registry API to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it must be validated if the selected schema is be compatible to the actual data being produced. We can check the original schema against the selected one by using this method:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apurvam How shall we continue? Should I adjust the text?
This KLIP likely overlaps with #3634. |
Causing CI to break due to the "unknown repository" - This needs to be closed to get around that. If this change is still required, please re-do it. |
Description
Design proposal to support
WITH (OUTPUT_SCHEMA='<schema-name>')
Related issues:
Testing done
Reviewer checklist