Fix clickstream instructions #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some issues with the clickstream instructions. From 4.1 onwards ksql is included with cp, so we don't need a separate step for starting up the ksql server. We also just need to run 'ksql' to start the cli. This patch also removes references to the local quickstart, which has not been working for the last couple releases.
dguy
reviewed
Apr 9, 2018
| @@ -164,17 +166,11 @@ Load the Streaming Data to KSQL | |||
|
|
|||
| #. Launch the KSQL CLI in Client Server Mode. | |||
|
|
|||
| 1. Start the KSQL server. | |||
| 1. Start the CLI and point it to the server. | |||
There was a problem hiding this comment.
Because we aren't actually pointing it to the server should we remove that part of the sentence?
miguno
reviewed
Apr 9, 2018
| @@ -164,17 +166,11 @@ Load the Streaming Data to KSQL | |||
|
|
|||
| #. Launch the KSQL CLI in Client Server Mode. | |||
There was a problem hiding this comment.
This should just be "Launch the KSQL CLI". The CLI only has no other mode today than client-server.
cc @joel-hamill |
|
Note:
@rodesai : I think you mean "removes references to the local clickstream demo", right? |
|
YES - definitely not the local quick start. I’ll update the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues with the clickstream instructions. From 4.1 onwards
ksql is included with cp, so we don't need a separate step for
starting up the ksql server. We also just need to run 'ksql' to
start the cli.
This patch also removes references to the local clickstream, which
has not been working for the last couple releases.