moved duplicate exceptions to one function (#396)

confluentinc · Oct 18, 2017 · e5be386 · e5be386
1 parent a612d26
commit e5be386
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/client/KsqlRestClient.java b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/client/KsqlRestClient.java
@@ -170,7 +170,7 @@ public QueryStream(Response response) {
     @Override
     public boolean hasNext() {
       if (closed) {
-        throw new IllegalStateException("Cannot call hasNext() once closed");
+        throw closedIllegalStateException("hasNext()");
       }
 
       if (bufferedRow != null) {
@@ -197,7 +197,7 @@ public boolean hasNext() {
     @Override
     public StreamedRow next() {
       if (closed) {
-        throw new IllegalStateException("Cannot call next() once closed");
+        throw closedIllegalStateException("next()");
       }
 
       if (!hasNext()) {
@@ -212,13 +212,18 @@ public StreamedRow next() {
     @Override
     public void close() {
       if (closed) {
-        throw new IllegalStateException("Cannot call close() when already closed");
+        throw closedIllegalStateException("close()");
       }
 
       closed = true;
       responseScanner.close();
       response.close();
     }
+
+    private IllegalStateException closedIllegalStateException(String methodName) {
+      return new IllegalStateException("Cannot call " + methodName + " when QueryStream is closed");
+    }
+
   }
 
   public Map<String, Object> getLocalProperties() {