Skip to content

Commit

Permalink
fix: Enables ALPN for internal requests when http2 and tls are in use (
Browse files Browse the repository at this point in the history
…#8094)

* fix: Enables ALPN for internal requests when http2 and tls are in use
  • Loading branch information
AlanConfluent authored Sep 2, 2021
1 parent 4831e6b commit 7faf77c
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import java.util.Optional;
import java.util.function.BiFunction;
import java.util.function.Function;
import java.util.function.Supplier;

public final class InternalKsqlClientFactory {

Expand Down Expand Up @@ -60,9 +59,9 @@ public static KsqlClient createInternalClient(

private static Function<Boolean, HttpClientOptions> httpOptionsFactory(
final Map<String, String> clientProps, final boolean verifyHost,
final Supplier<HttpClientOptions> optionsSupplier) {
final Function<Boolean, HttpClientOptions> clientOptions) {
return (tls) -> {
final HttpClientOptions httpClientOptions = optionsSupplier.get();
final HttpClientOptions httpClientOptions = clientOptions.apply(tls);
if (!tls) {
return httpClientOptions;
}
Expand All @@ -89,11 +88,12 @@ private static Function<Boolean, HttpClientOptions> httpOptionsFactory(
};
}

private static HttpClientOptions createClientOptions() {
private static HttpClientOptions createClientOptions(final boolean tls) {
return new HttpClientOptions().setMaxPoolSize(100);
}

private static HttpClientOptions createClientOptionsHttp2() {
return new HttpClientOptions().setHttp2MaxPoolSize(100).setProtocolVersion(HttpVersion.HTTP_2);
private static HttpClientOptions createClientOptionsHttp2(final boolean tls) {
return new HttpClientOptions().setHttp2MaxPoolSize(100).setProtocolVersion(HttpVersion.HTTP_2)
.setUseAlpn(tls);
}
}

0 comments on commit 7faf77c

Please sign in to comment.