Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-2298: address how nulls are handled in ksqlDB; DEVX-2310: rename ksqlDB query #316

Merged
merged 11 commits into from
Jan 6, 2021

Conversation

ybyzek
Copy link
Contributor

@ybyzek ybyzek commented Dec 29, 2020

Description

https://confluentinc.atlassian.net/browse/DEVX-2298
https://confluentinc.atlassian.net/browse/DEVX-2310

What behavior does this PR change, and why?

cc: @javabrett because there will be an impact to #300

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

Copy link

@mikebin mikebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor questions.

scripts/ksqlDB/statements.sql Outdated Show resolved Hide resolved
scripts/start.sh Outdated Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
@ybyzek ybyzek changed the title DEVX-2298: ksqlDB: address how nulls are handled in ksqlDB queries in cp-demo DEVX-2298: address how nulls are handled in ksqlDB; DEVX-2310: rename ksqlDB query Dec 30, 2020
docs/index.rst Outdated Show resolved Hide resolved
Copy link

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybyzek ybyzek merged commit 8fb064b into 6.1.x Jan 6, 2021
@ybyzek ybyzek deleted the DEVX-2298 branch January 6, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants