-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVX-2298: address how nulls are handled in ksqlDB; DEVX-2310: rename ksqlDB query #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebin
reviewed
Dec 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of minor questions.
ybyzek
changed the title
DEVX-2298: ksqlDB: address how nulls are handled in ksqlDB queries in cp-demo
DEVX-2298: address how nulls are handled in ksqlDB; DEVX-2310: rename ksqlDB query
Dec 30, 2020
3 tasks
javabrett
reviewed
Jan 1, 2021
bbejeck
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://confluentinc.atlassian.net/browse/DEVX-2298
https://confluentinc.atlassian.net/browse/DEVX-2310
What behavior does this PR change, and why?
null
values in window'd ksqlDB stream, made possible by Avoid outputnull
values when HAVING clauses not met ksql#3558 (cc: @big-andy-coates). Thanks for surfacing this @mikebinen_wikipedia_gt_1
towikipedia_count_gt_1
to have common wikipedia prefix to simplify role bindings and visuallycc: @javabrett because there will be an impact to #300
Author Validation
Describe the validation already done, or needs to be done, by the PR submitter.
Reviewer Tasks
Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.