Fix Backward Compatibility Issue in TopicPartitionOffset Constructor (#…

…2066) * Fix backwards compatability of TopicPartitionOffset constructor #2060 * Fix bug and add changelog --------- Co-authored-by: drinehim <[email protected]>
confluentinc · Jul 3, 2023 · d22cac9 · d22cac9
1 parent 3a0aa64
commit d22cac9
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+# 2.2.0
+
+## Fixes
+
+- Fix backwards compatability of TopicPartitionOffset constructor. ([drinehimer](https://github.com/drinehimer), #2066)
+
+
 # 2.1.1
 
 ## Enhancements

diff --git a/src/Confluent.Kafka/TopicPartitionOffset.cs b/src/Confluent.Kafka/TopicPartitionOffset.cs
@@ -23,6 +23,18 @@ namespace Confluent.Kafka
     /// </summary>
     public class TopicPartitionOffset
     {
+        /// <summary>
+        ///     Initializes a new TopicPartitionOffset instance.
+        /// </summary>
+        /// <param name="tp">
+        ///     Kafka topic name and partition.
+        /// </param>
+        /// <param name="offset">
+        ///     A Kafka offset value.
+        /// </param>
+        public TopicPartitionOffset(TopicPartition tp, Offset offset)
+            : this(tp.Topic, tp.Partition, offset, null) { }
+
         /// <summary>
         ///     Initializes a new TopicPartitionOffset instance.
         /// </summary>
@@ -36,8 +48,24 @@ public class TopicPartitionOffset
         ///     The offset leader epoch (optional).
         /// </param>
         public TopicPartitionOffset(TopicPartition tp, Offset offset,
-                                    int? leaderEpoch = null)
-            : this(tp.Topic, tp.Partition, offset, leaderEpoch) {}
+                                    int? leaderEpoch)
+            : this(tp.Topic, tp.Partition, offset, leaderEpoch) { }
+
+        /// <summary>
+        ///     Initializes a new TopicPartitionOffset instance.
+        /// </summary>
+        /// <param name="topic">
+        ///     A Kafka topic name.
+        /// </param>
+        /// <param name="partition">
+        ///     A Kafka partition.
+        /// </param>
+        /// <param name="offset">
+        ///     A Kafka offset value.
+        /// </param>
+        public TopicPartitionOffset(string topic, Partition partition,
+                                    Offset offset)
+            : this(topic, partition, offset, null) { }
 
         /// <summary>
         ///     Initializes a new TopicPartitionOffset instance.
@@ -55,7 +83,7 @@ public TopicPartitionOffset(TopicPartition tp, Offset offset,
         ///     The optional offset leader epoch.
         /// </param>
         public TopicPartitionOffset(string topic, Partition partition,
-                                    Offset offset, int? leaderEpoch = null)
+                                    Offset offset, int? leaderEpoch)
         {
             Topic = topic;
             Partition = partition;