Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jackson related packages #446

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Upgrade jackson related packages #446

merged 2 commits into from
Apr 26, 2022

Conversation

xjin-Confluent
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@xjin-Confluent
Copy link
Contributor Author

The only build failure is on ksql downstream validation and it is spot bug:

16:09:44  [ERROR] Return value of java.util.function.BiFunction.apply(Object, Object) ignored, but method has no side effect [io.confluent.ksql.engine.rewrite.ExpressionTreeRewriterTest] At ExpressionTreeRewriterTest.java:[line 140] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT

@xjin-Confluent xjin-Confluent requested a review from a team April 22, 2022 22:40
@xjin-Confluent
Copy link
Contributor Author

Known spot bug error in ksql:

16:09:44  [ERROR] Return value of java.util.function.BiFunction.apply(Object, Object) ignored, but method has no side effect [io.confluent.ksql.engine.rewrite.ExpressionTreeRewriterTest] At ExpressionTreeRewriterTest.java:[line 140] RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
16:09:44  [ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:3.1.12:check (default) on project ksql-engine: failed with 1 bugs and 0 errors -> [Help 1]
16:09:44  [ERROR] 
16:09:44  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
16:09:44  [ERROR] Re-run Maven using the -X switch to enable full debug logging.
16:09:44  [ERROR] 
16:09:44  [ERROR] For more information about the errors and possible solutions, please read the following articles:
16:09:44  [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
16:09:44  [ERROR] 
16:09:44  [ERROR] After correcting the problems, you can resume the build with the command
16:09:44  [ERROR]   mvn <args> -rf :ksql-engine

@xjin-Confluent xjin-Confluent merged commit 07d43b9 into 5.4.x Apr 26, 2022
@xjin-Confluent xjin-Confluent deleted the upgrade-jackson branch April 26, 2022 01:16
mjsax added a commit to confluentinc/ksql that referenced this pull request Apr 27, 2022
Jackson was bumped upstream: confluentinc/common#446

Version 2.13 returns null instead of NullNode (cf FasterXML/jackson-databind#3389)
mjsax added a commit to confluentinc/ksql that referenced this pull request Apr 27, 2022
Jackson was bumped upstream: confluentinc/common#446

Version 2.13 returns null instead of NullNode (cf FasterXML/jackson-databind#3389)
mjsax added a commit to confluentinc/ksql that referenced this pull request Apr 27, 2022
Jackson was bumped upstream: confluentinc/common#446
    
Version 2.13 returns null instead of NullNode (cf FasterXML/jackson-databind#3389)
mjsax added a commit to confluentinc/ksql that referenced this pull request Apr 27, 2022
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.databind.version}</version>
Copy link
Member

@arvindth arvindth May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd missed this during the original changes, sorry about that. We really shouldn't be adding individual jackson modules to the common pom. The whole point of using the bom is to only have that one place where these are defined. Otherwise all future updates need to update both the bom and these.

We should just remove all version properties and dependencies other than the bom version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants