Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts with gray text #33

Merged
merged 3 commits into from
Feb 23, 2015
Merged

Alerts with gray text #33

merged 3 commits into from
Feb 23, 2015

Conversation

kasperp
Copy link
Member

@kasperp kasperp commented Feb 19, 2015

@configit/ux cc: @AButler

@petefoll noted that the alerts texts in Ace are hard (due to lack of contrast). This pull request explorers different options for solving this problem. Below is a list of screenshot with alternative solutions to the problem.

For reference this screenshot shows the current alerts.
original

  1. Dark gray text color 🌑 :
    dark-gray
  2. Lighter gray text color ☁️ :
    gray
  3. Text color is dark but toned with the alerts contextual color 🌓:
    gray-toned

Alternatives
Doesn't use background color for context:

  1. Muted 😑:
    alternative-muted
  2. Bright 😎:
    alertnative-bright
  3. Bright and Muted 😎😑:
    alertnative-bright-and-muted

@AButler
Copy link
Contributor

AButler commented Feb 19, 2015

I prefer exactly the same as @kasperp 👍

@ghost
Copy link

ghost commented Feb 19, 2015

Ditto for me 👍 (tho I also like hollow muted too)

@LauraAB
Copy link

LauraAB commented Feb 20, 2015

#2 - easiest to read of the first three

Also like the last ones, and think they could make a nice change for the future - would like to see them in Ace to get a sense of how they could work. But, that's not for now :)

Thanks Kasper :)

@petefoll
Copy link

Hmmm. There seems to be a disconnect between what Bootstrap says things should be and with what Ace is currently using. See the images below:

red alert fw

blue alert fw

My background is educational publishing, where accessibility was taken very seriously, especially since Pearson UK had to accommodate its content being used in the States were the laws are much tighter and awareness higher. Simply passing at AA for large text isn't good enough for the body copy.

The Bootstrap Components page has different values - http://getbootstrap.com/components/#alerts.

If we use these values then I'd have no qualms about keeping the Bootstrap colours and design.

I can't see why we would ever want to 'mute' warning messages; they're warning, they should be front and centre and NOT blend in. If we fade them back too much they might end up as subtle as the breadcrumb trail.

I definitely vote to go with the correct Bootstrap colours.

@kasperp
Copy link
Member Author

kasperp commented Feb 20, 2015

@petefoll thanks for your feedback - it is great to have someone on the team that focus on and knows what it takes to be serious about accessibility.

The bootstrap page you compared to is the latest release of Bootstrap which isn't the one Ace is currently using. Ace is using a Configit fork here http://configit.github.io/bootstrap/. However the commit for fixing the colors should be on our version here. 4386650

Would you mind running the tool again on the version of Bootstrap that is in ACE, and check if there is any differences?

We could change colors of the alerts in our version to match the alerts in the latest version of Bootstrap. However I still think the version with the lighter gray text both looks better and is easier to read. I'm not convinced that changing the text color as well as the background color makes them easier to notice.

I can't see why we would ever want to 'mute' warning messages;

It is hard to disagree with this however there are other ways of make warning messages pop, than just changing the background color. You could animate them in, you could place them on top of another element, you could place them in a very prominent position on the screen (like top left), ....

In Ace there are currently many places (e.g. compile page and update workitem page, etc.) where we do not use the alerts as alerts, but more as "informational boxes". In these cases you don't need the message to pop (as they will take focus from the real content), here the alternative alerts with the white background could be a better option.

@petefoll
Copy link

Okay. My screenshots were taken from current live Ace screens and gave:
Blue alert: Foreground:#3A87AD Background:#D9EDF7
Red alert: Foreground:#B94A48 Background:#F2DEDE

The latest Bootstrap, which does have a AA-passing, uses:
Blue alert: Foreground:#31708F Background:#D9EDF7
Red alert: Foreground:#A94442 Background:#F2DEDE

We could do a quick fix to get the compliance by making the font in alerts a consistent grey like #534E53 (I can't get a clean sample of your lighter grey from the image). Which would give the below:

red alert with grey fw

@kasperp kasperp force-pushed the alerts-with-contrast branch from d8114a2 to 1fd7f2b Compare February 22, 2015 13:54
@kasperp kasperp changed the title Alerts with contrast - WIP Alerts with gray text Feb 22, 2015
@infoBorder: darken(spin(@infoBackground, -10), 7%);


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains the only real change, the rest are auto-generated dist and docs.

@kasperp
Copy link
Member Author

kasperp commented Feb 22, 2015

@petefoll the gray text color in my screenshot #2 is #555.

@AButler I'll assign this to you. The change now has the gray text color. Once merged I'll update the docs on http://configit.github.io/bootstrap/

AButler added a commit that referenced this pull request Feb 23, 2015
@AButler AButler merged commit bee3ef3 into master Feb 23, 2015
@AButler AButler deleted the alerts-with-contrast branch February 23, 2015 09:56
@kasperp
Copy link
Member Author

kasperp commented Feb 23, 2015

Thanks @AButler, docs are now updated.

@russelldocking
Copy link
Contributor

I know I'm a little bit late to the party here, but for what it's worth I'm not mad keen on the way #6 handles the join between the thick left border and the slim top and bottom borders. So when they're different colours, the border naturally ends up with a corner bevel which at this scale means an angled join rising 1 pixel along its 8 pixel length.
This effect is more pronounced when the colours are more different, and can be seen more clearly if you click through to the Bright and Muted example jpeg. I've made a more extreme example here:
bright-muted-corner
I think the best solution is to make the thick and thin borders in the same colour, or at least in more similar colours. This would be the simplest way to ensure that a change could easily be made Ace-wide.
If we wanted to get clever we could add another div to create the left-hand block inside a full border, but this could mean editing each individual alert!

@ghost
Copy link

ghost commented Jun 10, 2016

We can easily encapsulate multiple html elements into one semantic component - infact I think we already do this to some extend.

For example:

<configit-alert type="error">You did something wrong</configit-alert>

Could render into the browser as:

<div class="alert-side alert-side-error">
  <img src="error.gif">
</div>
<div class="alert-body alert-body-error">
  You did something wrong
</div>

Where the type being 'error' would be used as a variable inside the component.

We use this technique extensively to reduce errors and make refactoring easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants