Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtle memory leak issue #97

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Fix subtle memory leak issue #97

merged 5 commits into from
Nov 23, 2023

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Nov 10, 2023

Describe the purpose of your pull request

A hook event handler which closes over the client instance should not prevent the client from being collected by the GC when user has no more references to the client.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner November 10, 2023 12:40
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2b8f955) 91.75% compared to head (1fe7fa5) 91.65%.

❗ Current head 1fe7fa5 differs from pull request most recent head 5b0c149. Consider uploading reports for the commit 5b0c149 to get more accurate results

Files Patch % Lines
src/ConfigCatClient.ts 64.70% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   91.75%   91.65%   -0.11%     
==========================================
  Files          18       18              
  Lines        1613     1629      +16     
  Branches      408      411       +3     
==========================================
+ Hits         1480     1493      +13     
- Misses        132      135       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adams85 adams85 force-pushed the fix/closure-memory-leak branch from 477342c to 9f45459 Compare November 10, 2023 12:53
@adams85 adams85 force-pushed the fix/closure-memory-leak branch from 9977005 to 45089a0 Compare November 13, 2023 10:33
… issues with GC when awaiting IConfigCatClient.waitForReady
@adams85 adams85 force-pushed the fix/closure-memory-leak branch from 66f856b to 1fe7fa5 Compare November 18, 2023 20:19
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adams85 adams85 merged commit b21f14e into master Nov 23, 2023
@adams85 adams85 deleted the fix/closure-memory-leak branch November 23, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants