Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable ci tests on arm64 #890

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

seungukshin
Copy link

This changes enables CI tests on arm64 runner.

Ther guest-components's CI is as following: (${\color{red}red}$ parts are added by this change, links are test results on forked repo.)

@seungukshin seungukshin requested a review from a team as a code owner January 28, 2025 13:40
Signed-off-by: Seunguk Shin <[email protected]>
Reviewed-by: Nick Connolly <[email protected]>
@seungukshin
Copy link
Author

rust on aarch64-unknown-linux-gnu has a bug which faces SIGSEGV intermittently (rust-lang/rust#135867) with 1.83.0 or later. I added a commit to use rust 1.82.0 instead.

PR test results in the forked repo.: seungukshin#4

@seungukshin
Copy link
Author

Retest with new rust stable (1.84.0 -> 1.84.1) passed, so I removed the commit to force 1.82.0.

PR test results in the forked repo.: seungukshin#5

@seungukshin
Copy link
Author

Possibility is reduced, but getting SIGSEGV happened from time to time.

Added a commit to make arm64 uses 1.82.0 only and the rest of architecture use the same (stable and 1.83.0)

PR test results in the forked repo.: seungukshin#5

@seungukshin seungukshin force-pushed the arm64-ci branch 3 times, most recently from fd54a8f to 72323aa Compare February 5, 2025 10:40
@seungukshin
Copy link
Author

It seems one random test case kept failing at Code Checkout step every retry.

It does not contain any error message and it couldn't be reproduced in the forked repo. Could anyone help me to retry with debug enabled?

@seungukshin
Copy link
Author

The symptom is reproduced in my forked repository with debug messages - https://github.com/seungukshin/guest-components/actions/runs/13181422832/job/36844956217
The Code checkout failed without any error message with 139 exit code, but the checkout proceeded.
It seems node got a segfault some reason, but there is no message about it (nodejs/node#5769)

rust on aarch64-unknown-linux-gnu has a bug which faces SIGSEGV
intermittently (rust-lang/rust#135867)
with 1.83.0 or later.
rust 1.82.0 will be used for arm64 only until the above issue is resolved.

Signed-off-by: Seunguk Shin <[email protected]>
@seungukshin
Copy link
Author

@stevenhorsman , @zvonkok and @fidencio , could you take a look on this? Now all CI test cases passed.

@@ -29,17 +29,32 @@ jobs:
defaults:
run:
working-directory: ./attestation-agent
runs-on: ubuntu-24.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe it would be more concise if we'd have ternary construct picking an arm-runner in runs-on for cca-attester and a similar exception for rust?

Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thank you very much! @seungukshin

@huoqifeng huoqifeng merged commit 54c0a1f into confidential-containers:main Feb 12, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants