-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enable ci tests on arm64 #890
Conversation
Signed-off-by: Seunguk Shin <[email protected]> Reviewed-by: Nick Connolly <[email protected]>
rust on aarch64-unknown-linux-gnu has a bug which faces SIGSEGV intermittently (rust-lang/rust#135867) with 1.83.0 or later. I added a commit to use rust 1.82.0 instead. PR test results in the forked repo.: seungukshin#4 |
Retest with new rust stable (1.84.0 -> 1.84.1) passed, so I removed the commit to force 1.82.0. PR test results in the forked repo.: seungukshin#5 |
Possibility is reduced, but getting
Added a commit to make arm64 uses 1.82.0 only and the rest of architecture use the same (stable and 1.83.0) PR test results in the forked repo.: seungukshin#5 |
fd54a8f
to
72323aa
Compare
It seems one random test case kept failing at
It does not contain any error message and it couldn't be reproduced in the forked repo. Could anyone help me to retry with debug enabled? |
The symptom is reproduced in my forked repository with debug messages - https://github.com/seungukshin/guest-components/actions/runs/13181422832/job/36844956217 |
72323aa
to
63899fc
Compare
rust on aarch64-unknown-linux-gnu has a bug which faces SIGSEGV intermittently (rust-lang/rust#135867) with 1.83.0 or later. rust 1.82.0 will be used for arm64 only until the above issue is resolved. Signed-off-by: Seunguk Shin <[email protected]>
63899fc
to
adb997f
Compare
@stevenhorsman , @zvonkok and @fidencio , could you take a look on this? Now all CI test cases passed. |
@@ -29,17 +29,32 @@ jobs: | |||
defaults: | |||
run: | |||
working-directory: ./attestation-agent | |||
runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe it would be more concise if we'd have ternary construct picking an arm-runner in runs-on
for cca-attester
and a similar exception for rust?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you very much! @seungukshin
This changes enables CI tests on arm64 runner.
Ther guest-components's CI is as following: (${\color{red}red}$ parts are added by this change, links are test results on forked repo.)