Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use rustlang gh wf to install rust in cdh/aa/asr ci #813

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Nov 20, 2024

This will also set up build cache and is consistent with the AA CI workflow.

@mkulke mkulke requested a review from a team as a code owner November 20, 2024 08:50
@Xynnn007
Copy link
Member

The GHA has been archived. Would you try to use

      - name: Install Rust toolchain (${{ env.RUSTC_VERSION }})
        uses: actions-rust-lang/setup-rust-toolchain@v1
        with:
          toolchain: ${{ env.RUSTC_VERSION }}
          components: rustfmt, clippy

https://github.com/actions-rust-lang/setup-rust-toolchain

@mkulke
Copy link
Contributor Author

mkulke commented Nov 20, 2024

The GHA has been archived. Would you try to use

      - name: Install Rust toolchain (${{ env.RUSTC_VERSION }})
        uses: actions-rust-lang/setup-rust-toolchain@v1
        with:
          toolchain: ${{ env.RUSTC_VERSION }}
          components: rustfmt, clippy

https://github.com/actions-rust-lang/setup-rust-toolchain

oh, right. I wanted to use that. I just copied it from the AA one, then let's fix it also for AA + ASR

@mkulke mkulke force-pushed the mkulke/use-rustlang-action-in-cdh-ci branch 2 times, most recently from 60c070d to 362e904 Compare November 20, 2024 09:14
@mythi
Copy link
Contributor

mythi commented Nov 20, 2024

I just copied it from the AA one, then let's fix it also for AA + ASR

@mkulke thanks for getting the work started! minor nit: the commit title could be adjusted to reflect this ^

I'll try to get a couple of other .ymls updated too...

@mkulke mkulke changed the title ci: use rustlang gh wf to install rust in cdh ci ci: use rustlang gh wf to install rust in cdh/aa/asr ci Nov 20, 2024
This will also set up build cache and is consistent with the AA
CI workflow.

drive-by fix: switched to the non-archived rust-lang gh action for AA
and ASR worflows

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke force-pushed the mkulke/use-rustlang-action-in-cdh-ci branch from 362e904 to c2638a5 Compare November 20, 2024 11:16
@mkulke mkulke merged commit d607f9a into confidential-containers:main Nov 20, 2024
9 checks passed
@mkulke mkulke deleted the mkulke/use-rustlang-action-in-cdh-ci branch November 20, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants