-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ADOPTERS.md #226
Create ADOPTERS.md #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple of minor changes suggested,
beyond that looks like a good starter page to kick things off
Thanks
Adding the list of adopters for CoCo Signed-off-by: Ariel Adam <[email protected]> Update ADOPTERS.md Update ADOPTERS.md
@magowan I've added the relevant changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ariel-adam . only some nits
- **End-User** (CNCF member) - Companies and organizations who are End-User members of the CNCF | ||
- **Another project** - an open source project that leverages a CNCF project as part of their solution, integrates with for compatibility and interoperability, | ||
or is used in the supply chain of another project | ||
- **end users** (non CNCF member)- companies and organizations that are not CNCF End-User members that use the project and cloud native technologies internally, or build upon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **end users** (non CNCF member)- companies and organizations that are not CNCF End-User members that use the project and cloud native technologies internally, or build upon | |
- **End Users** (non CNCF member)- companies and organizations that are not CNCF End-User members that use the project and cloud native technologies internally, or build upon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it actually need to be "end users" and not "End users" :-).
Please see the CNCF guidelines https://github.com/cncf/toc/blob/main/FAQ.md#what-is-the-definition-of-an-adopter
This page contains a list of organizations/companies and projects/products who use confidential containers as adopters in different usage levels (development, beta, production, GA etc...) | ||
|
||
**NOTE:** For adding your organization/company and project/product to this table (alphabetical order) fork the repository and open a PR with the required change. | ||
See list of adopter types at the bottom of this page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See list of adopter types at the bottom of this page. | |
See list of adopter types in [Adopter Types][1]. | |
[1]: #adopter-types |
Then we can have a hyperlink of markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can differ the change to after the basic page was merged?
I'm not familiar with hyperlink markdown within the page and I won't really have time today to look into it and make sure it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding the list of adopters for CoCo